sass, flexbox, javascript for form validation

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  Nice work, Ben! I've got a few recommendations after taking a look at your solution:

  • On desktop, the background doesn't stretch to fit the height of the viewport. So there's a big white gap at the bottom of the screen.
  • You could increase your media query from max-width: 375px. At the moment, from 376px up to tablet the content looks very squashed.
  • Have a go at removing the accessibility errors. input elements should always be paired with a label which outlines the information the user should be adding to that input. Without it, users with screen readers won't be able to fill in the form.

  Let me know if you have any questions. Keep up the great work! 👍

  0

  ---

  

  bwhitney2439•545

  @bwhitney2439Posted almost 5 years ago

  @mattstuddert thanks for the feedback. I’ll make the amendments.

  0