Sass, flex, mobile first, responsive,sortable.js

Community feedback

• 

  Dima Prohorenko•180

  @SassCrafterPosted almost 4 years ago

  Hi, thanks for your feedback, yeah I gotta label inputs and I'll try to preload image. Have a nice day and stay safe:)

  1

  ---

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  @WebDevLite

  You too! 👍

  0
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, Dima Prohorenko! 👋

  Nice work on this challenge! 👍 I like the custom to-do tasks you added! 😉

  In addition to dpayne713's helpful feedback, I only suggest taking a look at your solution report and trying to clear up the errors that are there (probably by labeling some of the input elements on the page in some way to make your solution more accessible).

  Also, preloading the image for the light theme of the page might be a good idea so that there is no delay between when the theme changer button is clicked for the first time and the image appears. I think it would be a nice touch! 😊

  Keep coding (and happy coding, too)! 😁

  1
• 

  David Payne•1,205

  @dpayne713Posted almost 4 years ago

  Hi! Nice Job! Love the drag and drop feature.

  I found a couple bugs that hopefully help improve your project:

  • On the newly created to-do's you are adding an image tag inside of the .todos__delete div. This is blocking the event listener on the .todos__delete div as you are actually clicking on the newly inserted <i> element. It looks like this node is unnecessary. When I delete the image node the 'X' remains and the delete functionality returns.

  • I also noticed that clicking in the white space to the right of the 'X' causes some odd collapsing behavior of the list. My guess is this is caused by event bubbling / event.target triggering something you don't want - which can be easily fixed with an 'if' statement within the event listeners.

  Keep it up! David

  1

  ---

  

  Dima Prohorenko•180

  @SassCrafterPosted almost 4 years ago

  @dpayne713 Thank you, yeah I noticed the collapsing bug after submiting the solution, and I forgot to delete the part of code that adds image tag)). Thanks again, stay safe and have nice time coding.

  0