SASS, CSS

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • You are using the Article Element incorrectly. In order to use the Article Element it needs to be able to stand on its own and is independently reusable (it can be used in other sites). These testimonials cannot do either.

  Instead, you want to wrap each individual testimonial component in a Figure Element, the individuals information should be wrapped in a Figcaption Element and lastly, the testimonial itself should be wrapped in a Blockquote Element.

  Code:

  <figure>
     <figcaption></figcaption>
     <blockquote></blockquote>
  </figure>
  

  More Info:

  ARTICLE

  • The headings in your component are being used incorrectly. Since the <h1> Heading can only be used once, it is always given to the heading with the highest level of importance. So the best option would be to use an <h2> Heading, since it is reusable and it will give each heading the same level of importance.

  • Some of the background colors are being used incorrectly. The light blue should be the main background and the "Kira Whittle" and "Jeanette Harmon" testimonial should have a white background.

  If you have any questions or need further clarification, let me know.

  Happy Coding! 👻🎃

  Marked as helpful

  0