Skip to content
Submitted about 3 years ago

Sass Componen Card ❤️‍🔥

Ramy Campusano Volquez•340
@Daniels-not
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Order summary component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

There's an issue in the description paragraph witch it's not center when is on mobile 💡. feedback helps me to perform my web development skills ✨.

Community feedback

  • darryncodes•6,390
    @darryncodesPosted about 3 years ago

    Hi Ramy,

    Really good solution, looks pretty close to me!

    • you could add min-height: 100vh; to you .center to center everything nicely in the viewport
    • you could remove the background image on mobile: @media only screen and (max-width: 600px) { body { background-image: none; } }
    • your <section class="center"> should be <main class="center"> and your <div class="attribution"> should be <footer class="attribution"> semantic html info
    • your <h4> should be a <h2> you shouldn't skip heading levels

    Happy coding 🤙

    Marked as helpful
    0
    Ramy Campusano Volquez•340
    @Daniels-notPosted about 3 years ago

    @darryncodes thanks for your feedback ❤️‍🔥

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord