Sass, BEM with desktop first desgin

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted over 5 years ago

  Great work on this challenge Clinton, you've done an awesome job! 👍

  Nice to see you using Sass and BEM as well. Your class naming looks good and your Sass structure also looks nicely separated and organised.

  Here are a few tips after taking a look at your code:

  • Your form errors are currently showing up immediately on page load. I would recommend hiding these errors and only showing them when the user actually tries to submit the form with invalid inputs.
  • Be sure to add a corresponding label for each input or add aria-label to the input elements. This will make sure screen reader users know what the form fields are for.
  • Add role="alert" to error messages in order to have the error messages read out to screen reader users when shown. Here's a great MDN resource with some tips on other ways to implement alerts effectively.
  • I would recommend trying to use min-width instead of max-width on a future project. Many people prefer using the mobile-first workflow and it also has added benefits, such as loading in fewer styles for mobile users.

  I hope these tips help, keep up the great work! 👍

  1