Built with BEM method, CSS Grids, Flexbox, SASS and Parcel Bundler.

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  This looks really good, well done!

  There are some issues with the html elements chosen. The headings used for the stats don't make semantic sense. It would be better if those stat__ elements were spans inside a list item or paragraph.

  In the css there is one big accessibility issue I can see. Because you have chosen to scale the root font size down to 10px but have not scaled it back up on the body element, it can cause big problems for users with various sight issues who need to change font sizes or zoom settings.

  Personally I advise against changing the root/html font size ever. Theres no good reason to do it, especially when using scss so you can work out rem values very easily with a function. If you do choose to reduce the base font size, it needs to come straight back up in rem on the body element, and on any other elements that don't inherit font-size.

  1

  ---

  

  Sergio Reynoso•320

  @sergioreynosoPosted over 3 years ago

  @grace-snow Thank you so much for the fantastic feedback. What's funny is that I had reservations about the stat__elements being headings as well. Regarding changing the root font size, those are excellent points. I will revert to leaving it at 16px and adapt.

  0