Design comparison
SolutionDesign
Community feedback
- @Theosaurus-RexPosted 10 months ago
Hey there! Congrats on completing the challenge!
A couple of small pieces of feedback:
- I don't think the
section
tags are particularly necessary here, but if you do want to use them I would be wrapping everything in them rather than just your text - I'd probably have the icon, all of the text and the "Learn More" CTA inside a section each. - You should have your heading tags outside of the paragraph tags - these are separate hierarchical elements that should be stacked one after another
- Use anchor tags instead of
button
for the "Learn More" CTAs. These are likely to be links to another part of a website, not buttons that a user is using to make a decision. Here is a great article to learn more about this. - Your
img
tags all need to have thealt
attribute to be valid. In this case, you can set the icons to havealt=""
, as they are purely decorative. Here is a handy article that covers how to make your SVGs accessible with alt text if you'd like to learn more.
Other than that, this overall looks pretty good! Your version seems a little stretched out horizontally compared to the design, so you may want to play with how it looks at a variety of screen sizes as well 🙂
0@dev0xgeniusPosted 9 months ago@Theosaurus-Rex Thanks a lot for the reply🤝🏽. I'll improve the solution.
0 - I don't think the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord