@pikapikamart
Posted
Hey, awesome job on this one. Layout looks really good in desktop, it is responsive and the mobile layout is good as well.
Some suggestions besides Marlon's great feedback again^:
- You don't need the first
div
that captures the whole layout. You could just use thebody
tag on this one. Also a preferred structure would be:
<body>
<header />
<main />
<footer />
</body>
This way, all content will be inside a landmark elements.
- Just to say it first, making carousel to be accessible is really hard, just pointing it out :>
- The website logo shouldn't be inside a
nav
element, since it is not really a navigational link of your website. Only those 4 elements after it is needed. - The
alt
value for theimg
of the website logo should have beenalt="room"
, since the website itself is named by that, better using it as a value for the website-logo'salt
attribute. - Always use only 1
h1
per webpage. It would be great if theh1
on this would be asr-only
text. This means the text will only be visible to screen-reader users. shop now
should be a link usinga
tag.- The
button
to change the carousel should havearia-label
defining what thebutton
does. For example, thebutton
for the next carousel item, it should be:
<button aria-label="next carousel item"> </button>
This way, there is an information on what this button
will do.
MOBILE
- The hamburger menu should have been using
button
element and not justdiv
. Using justdiv
makes it un-accessible for keyboard and screen-reader users. Always use interactive html element for an interactive component. - The
button
that you will use in the hamburger should havearia-label="navigation menu dropdown"
so that users will know what thisbutton
does. Thebutton
should also havearia-expanded="false"
as default value, and you will toggle it to true by javascript, if the user toggles thebutton
, then you just cycles it.
Aside from those, really great job on this one.
Marked as helpful