Design comparison
Solution retrospective
I use BEM and Tailwindcss together. In some complex CSS situations, it is more convenient to use traditional CSS. However, sometimes when adding CSS attributes, I hesitate whether to put this attribute in tailwind or in CSS.
Community feedback
- @Annalisa11Posted about 2 months ago
Hi Mofada, I really like your solution! I expecially like the fact that it is simple and it doesn't have too much code, but it does its job really well. I also like the tablet view very much :)
One thing I would say is that you used many px values for paddings and margins in tailwind. Since tailwind has very well thought through design system, I would try to personalize it as little as possible.
It's also recommanded to avoid px values since they don't scale very well, but that's a minor thing.All in all very nice! Good structure, readable and good names for everything and a good responsive website.
0@mofadaPosted about 2 months ago@Annalisa11 Hi Annalisa, Thank you for liking my solution.
When I finish my code, I will think about whether there is a better solution, and then continue to optimize my code. (Regarding the menu of the mobile phone, I have not found a better solution. What you see now is what I think is a better solution at present)
Finally, you mentioned the px problem. Because I don’t have a UI draft, I can only adjust it according to the px accuracy. Then every time I find that the px accuracy is the closest to the design draft, so I keep the px.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord