Room HomePage using HTML, SASS, JS

Community feedback

• 

  Sunny•525

  @statanasovaPosted almost 4 years ago

  This is a hard challenge and you did a great job :)

  I might be wrong here, but as long as the 'slider' and the 'about' sections are in two separate grids, I think it isn't possible to align the buttons with the left edge of the bottom image. In future-CSS specs, we are expecting to see sub-grids that would make such a task easier.

  Today, you still might be able to pull it of, by creating one big grid with carefully planned rows and columns and contents that span them. Honestly, I don't have enough grid skills to do this yet :) but if you want to know more about that approach, I highly recommend Jen Simmons' YouTube channel, she is a CSS Grid magician.

  Apart from that, I noticed:

  1. A vertical scroll appears for your menu on large screens.

  2. The prev and next controls for the slider are <div> elements, which makes them impossible to control with the keyboard. Try using buttons instead in such situations, it is much better for accessibility purposes as well :)

  Keep up the good work!

  2

  ---

  

  João Amaral•50

  @Jon2306Posted almost 4 years ago

  @statanasova Thank you for the advices!

  0

  

  Sunny•525

  @statanasovaPosted almost 4 years ago

  @Jon2306 PS. Check out this solution, Axelle used a grid for the whole thing and the buttons are sticking exactly where they should be. It's quite nice.

  Axelle's Room Homepage Solution

  0
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hello, João Amaral! 👋

  Good job on this challenge! 👏 I think the transitions between slider images and of the mobile navigation is nice and smooth! 🙌

  Simply follow statanasova's great advice and I think you'll be good to go! 👍

  Keep coding (and happy coding, too)! 😁

  0