Room Homepage (HTML, SCSS, JS - GSAP)

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hello, Jonathan Koh! 👋

  Nice effort on this challenge! 👏 It's cool to see you playing around with GSAP to add animations to your site! 😎

  I'd like to suggest,

  • Making sure the content of the page does not become too distanced from each other on extra-large screens (by adding a max-width to some elements, perhaps).
  • Adding overflow-x: hidden to the body of the page (or something similar) to prevent a horizontal scroll bar from appearing along the bottom of the page (due to the animations, I think).
  • Perhaps not switching to a mobile-friendly layout so soon, since, you could perhaps wait a little while to do so and the images in the mobile layout won't look a little blurry when the layout first changes from desktop to mobile. 😉

  Keep coding (and happy coding, too)! 😁

  0
• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  I have not build then yet so congrats on building it at 1212px the shop now goes and hides behind your flipper buttons and then honestly the transition right down below 1200px looks really strange but as I said I have not build this yet so I really do not know this layout enough to help

  0