Submitted about 2 years ago
Rock-Paper-Scissors-Lizard-Spock using SCSS
@DanielLucaci
Design comparison
SolutionDesign
Solution retrospective
Any feedback is highly appreciated.
Community feedback
- @AdrianoEscarabotePosted about 2 years ago
Hi Lucaci Daniel, how are you?
I really liked the result of your project, but I have some tips that I think you will enjoy:
- To improve the accessibility of the project you could have put an h1. Every page must contain a level 1 header, for people who use screen readers, identity what the main title is.
- Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.
The rest is great!
I hope it helps... 👍
Marked as helpful1@DanielLucaciPosted about 2 years ago@AdrianoEscarabote Hey, thanks for your feedback. I will take your tips into account. :)
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord