Rock paper sissors

Community feedback

• 

  Janos Takacs•230

  @JT1974Posted over 2 years ago

  Hi Giwa,

  You definitely love React components... 😂👍 That's great, I love them too. Your solution is working well, there's only a few suggestions (smaller ones) I would make: First of all, you left your console logs in the code, so it's logging your states for every click. The app is still functioning, so it's just something I you could consider. Secondly, the styling could be a bit more responsive, there's a lot of unused space in almost every resolution. You could try flexbox, and/or a few media queries, even in your styled components, it would definitely improve UX. Thirdly, a small issue, you forgot to remove the React icon and quite a few CRA assets from your folder structure. It was funny when I found a Netflix logo in one of your folders... 😂 🤷‍♂️ Anyway, overall I think it's a good and working solution, maybe the UI could be a little bit improved. Congratulations!

  0

  ---

  

  Giwa Muhammad•160

  @mgiwa78Posted over 2 years ago

  @JT1974 OMg thanks a lot for your suggestions, I really wasn't paying attention to a lot of things. I appreciate and will improve on further projects.

  1