Rock, Paper, Scissors with ReactJS

Community feedback

• 

  Andrew•380

  @andreich1980Posted over 2 years ago

  Hi Nadine

  I have a few recommendations for your code:

  • game.js You don't need else in there since every if returns something. And there's a trick to check who wins: you can add an array of choices that win for each choice or have a separate object of winners: { [CHOISES.ROCK]: [CHOICES.PAPER], <the choice>: [<choices that are defeated by the choice>], } The you decide the winner using includes.

  In the computer-turn.jsx you have a nested ternary operator for message. It looks weird and very hard to understand.

  Other than that everything looks good and is very close to the design! Good job

  Marked as helpful

  1

  ---

  

  Nadine•420

  @nadlgitPosted over 2 years ago

  @andreich1980 Thank you very much for this feedback !

  1