Rock Paper Scissors

Community feedback

• 

  Patrick Touchette•355

  @patricktouchettePosted almost 5 years ago

  Hi, good job on your solution. You are right that there are many if/elses. As you can see it gets confusing quickly :D. I would suggest using an extension called prettier in VScode, it can be setup to format on save. This will tremendously help code readability.

  You can simplify your logic by making use of arrays and objects. Here's how I would do it. It is by no means the best way, could probably be even more concise and cleaner.

  // Get player pick (this should be an input, not hardcoded)
  const playerPick = 'rock';
  // Get random pick for computer
  const choices = ['rock', 'paper', 'scissor'];
  const computerPick = choices[Math.floor(Math.random() * 3)];
  
  // Declare the ruleset as an object for win conditions
  // rock beats scissor
  // paper beats rock
  // sicssor beats paper
  const rules = {
    rock: 'scissor',
    paper: 'rock',
    scissor: 'paper',
  };
  
  // check if player won, lost or got a draw
  const compare = () => {
    if (playerPick === computerPick) return 'draw';
    if (rules[playerPick] === computerPick) return 'win';
    return 'lose';
  };
  
  console.log('playerPick', playerPick);
  console.log('computerPick', computerPick);
  console.log(compare());
  

  1

  ---

  

  P

  Lee•495

  @leecockcroftPosted almost 5 years ago

  Many thanks for your feedback :)

  0