Rock, Paper, Scissors game using React, Redux, Material-UI, RTG.

Community feedback

• 

  Mark Mitchell•1,820

  @markup-mitchellPosted over 4 years ago

  Yes.

  But you want a portfolio to be your best work, so you should resolve all outstanding issues with any projects you include. There are a lot of issues flagged in the automated report.

  This looks fantastic on desktop! You've done a great job with the transitions/animations.

  A couple of things I noticed:

  • I'm not sure the player score should decrement when they lose. Negative score looks like a bug, even if you intended it.
  • The outcome screen UI breaks on mobile.

  2

  ---

  

  Mohamad-Ilham-Ramadhan•430

  @Mohamad-Ilham-RamadhanPosted over 4 years ago

  @markup-mitchell Thank you very much for your answer. I don't have any real-life project like a freelance project to put on my portfolio, I'm not sure I can convince employer but now you convince me. About the decrement of the score, I follow it from README.md but yes... the negative score looks like a bug, and for the UI breaks on mobile maybe because of my last commit accidentally break it. I'll fix all the issues soon, thank you very much... God bless and happy coding.

  2

  

  Mark Mitchell•1,820

  @markup-mitchellPosted over 4 years ago

  @Mohamad-Ilham-Ramadhan haha! you're absolutely right! I guess I didn't read the requirements carefully enough :flushed: Ignore me on the score part!

  0

  

  Mohamad-Ilham-Ramadhan•430

  @Mohamad-Ilham-RamadhanPosted over 4 years ago

  @markup-mitchell haha, it's okay :)

  0