Skip to content
Submitted over 2 years ago

ROCK PAPER SCISSOR GAME (Vanilla JS , SASS using Gulp)

liezl•190
@liezsm
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Rock, Paper, Scissors game
  • HTML
  • CSS
  • JS
4advanced

Design comparison

SolutionDesign

Solution retrospective

As a beginner, still learning, lot of challenges but very proud to finish this one, the logic of the game wasn't that hard, the implementation of the design is a challenging one for me. Any feedbacks and suggestions are welcome 🙂

Community feedback

  • Travolgi 🍕•31,400
    @denieldenPosted over 2 years ago

    Hi liezl, great work on this challenge! 😉

    Here are a few tips for improve your code:

    • remove all unnecessary code, the less you write the better as well as being clearer: for example the comments
    • centering with margin is now not the best way, it uses modern css like flexbox or grid
    • remove all margin from header tag and game-container class
    • use flexbox to the wrapper class to center the element without margin

    Overall you did well 😁 Hope this help!

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord