RFIX_Solution_QR-Component-Front-end-mentor

Community feedback

• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  Hay ! Raul Pinero Good Job on challenge

  These below mentioned tricks will help you remove any Accessibility Issues

  -> Add Main tag after body <main class="container"></main>

  -> Learn more on accessibility issues

  If this comment helps you then pls mark it as helpful!

  Have a good day and keep coding 👍!

  Marked as helpful

  0

  ---

  

  Raul Pinero•50

  @RPinero-20Posted almost 3 years ago

  @Crazimonk Hi! thank you very much for the advice! i´ll keep in mind next time, and next, and next, and ... 😁 forever

  1
• 

  Yazdun•1,310

  @YazdunPosted almost 3 years ago

  Hey Raul great job on this, to get rid of accessibility issue, you must add a h1 heading to your main tag which tells what this page is about, it can be hidden, you can use a simple sr-only css class if you want to make it hidden.

  right now, as your website hits around 337px width, QR card sticks to the edge of the screen which is not the best user experience IMO, so make sure to use some paddings on QR code's parent element.

  in my opinion your box shadow is too thick, but hey, that's a personal opinion 😁

  well done and keep coding !

  Marked as helpful

  0

  ---

  

  Raul Pinero•50

  @RPinero-20Posted almost 3 years ago

  @Yazdun Thanks Yazdun, i´ll change it 😁.

  0
• 

  Hexer•3,660

  @EmmanuelHexerPosted almost 3 years ago

  Great job overall man.

  0

  ---

  

  Raul Pinero•50

  @RPinero-20Posted almost 3 years ago

  @Phalcin Thanks man! i´m on my way

  0