Review/Rating app built using React.js

Community feedback

• 

  szam•800

  @k-stopczynskaPosted about 2 years ago

  Hi!

  congratulations on finishing this challenge:) Looks really nice!

  Few things you might find helpful: I would probably split this into two different components in React in order to get more reusable code and more logic to the project.

  You are using Sass but you don't use mixins (there is a mixin file but it's empty). It's super helpfull to use them e.g. for media queries. Also variables can by anything you want, not just colors, you can get borders, border-radius, fonts, font-weights in there etc. That way you have more reusable code and make changes only in variables file. It is good practice to use specific file structure in Sass, this article will help you start: https://itnext.io/structuring-your-sass-projects-c8d41fa55ed4

  Happy coding!

  Marked as helpful

  1

  ---

  

  Louis Browyn•90

  @browynlouisPosted about 2 years ago

  @k-stopczynska Thank you so much for this feedback.

  I have split into two components already, the rating component and the appreciation component. I would like you to give a review whenever you feel convenient.

  However, in regards to using sass, this project was built with my default(INITIAL) project markup structure, so I didn't really intend to make use mixins and lots of variables as I felt it would too much for such a little project. I did take a look at the link you provided and I think I will follow that lead in structuring my sass in react projects. Thanks a lot.

  PS: I just finished the Notification page challenge, I absolutely won't mind a feedback on that also.

  0