Review Card

Community feedback

• 

  Adriano•38,330

  @AdrianoEscarabotePosted about 1 month ago

  Hi Sune Yde, how are you doing? I really loved the outcome of your project, but I have a few suggestions that I think might be helpful:

  Use the THE PICTURE TAG that is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

  Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

  See the example below:

  <picture>
    <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
    <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
  </picture>
  

  The rest is excellent.

  I hope you find it useful. 👍

  Marked as helpful

  1
• 

  Yacoub AlDweik•990

  @YacoubDweikPosted about 1 month ago

  Hey! Good job Danish guy well done!

  I don't think you should make the design be almost 100% of Width when it comes to screens like Tablets or IPads (I know you have some paddings but they're too small), Just give the design less width and the photo will be visible and good, take out that background position cuz it ruined it already, check out the real width of the photo then apply it for the parent.

  Another thing which is gonna be take your code to the next level is using BEM name convention for Class Names, take a l ook at it I am pretty much sure you will love, K eep it up Viking!

  Marked as helpful

  1