Design comparison
Solution retrospective
Going to as much challenge as possible in the coming weeks month, this the first one I complete.
Community feedback
- Account deleted
Hello there! π
Congratulations on finishing your challenge! π
I have some feedback on this solution:
- Always Use Semantic HTML instead of
div
like<main>
<header>
<footer>
, etc for more info
1@MarcusTuliusCiceronPosted over 2 years ago@Old1337 Ok thanks for feedback, will try to take care of this for next challenge
1 - Always Use Semantic HTML instead of
- @SamadeenPosted over 2 years ago
Hey Ciceron!! Cheers π₯ on completing your first challenge Here are my suggestions 1.You should use <main class="container"> instead of <div class="container">. 2. You can add margin-bottom to your card to push down the attribution a little bit down . Regardless you did amazing.. Happy coding
0 - @NaveenGumastePosted over 2 years ago
Hello Ciceron ! Congo π on completing this challenge
Let's look at some of your issues, shall we:
-
Add Main tag after body
<main class="container"></main>
happy Codingπ
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord