Design comparison
SolutionDesign
Solution retrospective
Had issues publishing the site with icons, any advices are welcome. Thanks!
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML π·οΈ:
- Your solution generates accessibility error reports due to
non-semantic
markup
- So fix it by replacing the
<div class="attribution">
with element<footer>
to improve accessibility and organization of your page.
- Use HTML5 semantic elements such as
<header>
,<nav>
,<main>
,<aside>
, and<footer>
to define these sections
I hope you find it useful! π Above all, the solution you submitted is great!
Happy coding!
Marked as helpful0@lazzsamPosted over 1 year ago@0xAbdulKhalid Thank you for the advice, it will be corrected. :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord