result-summary-component-main

Community feedback

• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="card"> element with the proper semantic element <main> in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• 

  Engineer Providence•310

  @EngProvidencePosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing your first challenge! 🎉

  I have some little observations, the border radius of the div are too much and the background color of the summary fields are suppose to be related to the main color but your own was consecutive in the first 3 fields. one more thing in a challenge try as much as possible to reproduce the exactly thesame thing

  I hope you find this helpful 😄 Above all, the solution you submitted is great!

  You can see my solution here: https://www.frontendmentor.io/solutions/responsive-single-price-grid-system-using-bootstrap-css-FCLZgXEOZb

  Happy coding from emperor pro!

  0