Submitted over 1 year ago

result-summary-component(flex/grid/gradient color)

Izzat Razab•70

@izzatrazab

Preview site View code

This is a solution for...Results summary component

HTML
CSS

1newbie

Design comparison

SolutionDesign

Solution retrospective

Please suggest me any best practice that be improve this code. I really want to become better at CSS.

Community feedback

Abdul Khaliq 🚀•72,560
@0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉

I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

This solution generates accessibility error reports due to non-semantic markup, which lack landmark for a webpage

So fix it by replacing the element <div id="app> the with semantic element <main> in your app.html file to improve accessibility and organization of your page.

What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

METADATA ♻️:

And, This solution has also generated accessibility error reports due to lack of title tag inside html element

<html> element must have a title tag, so fix it by adding <title>Result Summary Component</title> inside the html

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!
1
ohuttar•160
@ohuttarPosted over 1 year ago
Your solution looks great! It's working on both screen sizes. And I think your CSS makes sense to me.

I would improve the HTML though. You're currently missing a <head> on your HTML and it is not very semantic or accessible. Check out this website https://www.a11yproject.com/posts/how-to-accessible-heading-structure/ if you want to learn more about this. Particularly, it is recommended to not use heading tags for styling, but rather to use them for structuring content.

Anyways, I think you did a great job, and I hope my comment helps!
0

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord