Design comparison
Solution retrospective
Free judge please look the responsive part at 374px I don't know if its right but i will accept any recommendation to improve my work <3
Community feedback
- @MelvinAguilarPosted 10 months ago
Hello there 👋. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
-
To keep your CSS maintainable, it's important to keep the number of selectors to a minimum. Overusing many selectors can make your code harder to read and maintain, and can lead to specificity issues, making it difficult to override existing styles.
For example, this selector is too specific:
.summary .summary-content .content .contents .visual-content .text { }
Consider simplifying it for better maintainability and flexibility.
- When creating a media query, the goal is to override styles that can change between screen dimensions. There's no need to copy the same styles; only use the ones you need to change.
- Use semantic elements such as
<main>
and<footer>
to improve accessibility and organization of your page.
- Use
min-height: 100vh
instead ofheight
. Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding!
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord