Design comparison
Solution retrospective
This is was a really nice project for me. I definitely saw improvements in my coding. However, I'll very welcome tips for best practices and how to improve myself.
Community feedback
- @Saad-HishamPosted over 1 year ago
great job you have a small issue with the sizes I first want to recommend using software like photoshop to help you extract the sizes from the images and colors too now I will provide you with the correct sizes for this project add this line to this code
main { width: 736px; height: 513px; }
you can also remove this line it breaks the design on small screens
.score { /* width: 100%; */ }
Secondly, the footer breaks on small screens. To fix this, you can give it a fixed position and make sure it's placed at the bottom of the screen. Here's how:
.attribution { font-size: 11px; text-align: center; position: fixed; width: 100%; bottom: 0; }
One more thing, I noticed that you're adding the alt attribute to your images, which is great! However, it's important to make sure that the attribute is describing the image well. For example, instead of using alt="reaction", you can use alt="reaction block icon".
Overall, your solution was great. Keep up the good work🔥
Marked as helpful1 - @Kolade1024Posted over 1 year ago
Thanks a lot... I'll add the necessary changes. This was very helpful
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord