Design comparison
SolutionDesign
Solution retrospective
keep going on.
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML π·οΈ:
- This solution generates accessibility error reports due to
non-semantic
markup, which lack landmark for a webpage
- So fix it by replacing the
<div class="flex-container">
element with the semantic element<main>
along with<div class="attribution">
into a<footer>
a in yourindex.html
file to improve accessibility and organization of your page.
- What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like
<div>
or<span>
- They convey the structure of your page. For example, the
<main>
element should include all content directly related to the page's main idea, so there should only be one per page
iMAGES πΈ:
alt
text is a descriptive text attribute added to an HTML image tag that provides a textual description of an image for users who are visually impaired or cannot see the image for any other reason.
- The purpose of
alt
text is to convey the meaning and context of an image to these users so that they can understand the content and information conveyed by the image.
- But here, The
svg's
are just used as a decoration material.
- Meanwhile it also needs an
alt
attribute withempty
value
- Eg:
<img src="assets/images/icon-memory.svg" alt="" aria-hidden="true">
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord