Design comparison
Solution retrospective
the first responsive page !!!
Community feedback
- @SamdevtechnologyPosted over 1 year ago
Hi. Congratulations on a job well done! π π π
I would like to make some suggestions concerning your code that might be of help.
--- This webpage generate an "All page content should be contained by landmarks" error. ---
- This is caused by lack of landmarks for a webpage.
- Landmarks can be added to a webpage via semantic elements.
landmarks ? are use to provide a more precise detail of the structure of our webpage to the browser or screen readers. We make use of sematic elements to provide landmarks to our webpage example includes <main>, <aside>, <footer>, etc., instead of relying on generic elements like <div> or <span>.
- Every webpage should contain one <main> element and it should include all content directly related to the page's main idea, there should only be one per webpage
You can fix this on this webpage by replacing the <div class="header"> element with the semantic element <main> along with <div class="result"> and <div class="summary"> into a <section> element in your index.html file
- A <main> element to wrap all content of the component. and a <section> element to wrap each section of the component.
Well done for completing this challenge π
I hope have been of help, Please feel free to ask any question
Happy Coding π
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord