Design comparison
Solution retrospective
xD
Community feedback
- @danielmrz-devPosted 10 months ago
Hello @vasin-fr
You did a very good job there! Loved the zoom animation! π
I have just a few very simple suggestions for improvement:
-
First: Since the continue button is a clickable element, it's nice to add
cursor: pointer
to it. -
Second: For semantic reasons, and since that is the main title of the screen, you can replace the
<h3>
with<h1>
.
The
<h1>
to<h6>
tags are used to define HTML headings.<h1>
defines the most important heading.<h6>
defines the least important heading. Only use one<h1>
per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with<h1>
, then use<h2>
, and so on.- Third: Still about semantic HTML, you can wrap the main content with
main
instead ofsection
.
All these tag changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than those details, you did a great job!
Marked as helpful1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord