results-summary-component

Community feedback

• 

  Luka Glonti•3,440

  @lack21Posted over 1 year ago

  Good work 👍, but I have some recommendations!

  • Remove width: 100vw from the class .master, it's the block level element which by default takes the full space, so there's no need for width: 100vw.
  • Replace height: 100vh to min-height: 100vh in the class .master, the difference is that, when you set height: 100vh to something, that means it won't be bigger than that, it might cause some problems in the future, so better approach is to set min-height: 100vh, like this in case content is overflowing container will adjust to it.
  • Remove flex-direction: row from the class .card and .master, when you set display: flex by default flex-direction is row, so it does nothing here.

  0

  ---

  

  Ashray•110

  @RayAsh37Posted over 1 year ago

  @lack21 Thanks. I will implement them.

  0