results-summary-component

Community feedback

• 

  Fran Extremera•210

  @franexmo81Posted over 1 year ago

  Your solution looks really similar to the design. The responsiveness seems to work nicely. Well done!

  I would have named the CSS variables in such a way that their name is not referred to the color but for their use. Something like "primary-color" or "accent-color", etc.

  The idea behind it is that if the colors need to change in the future, you can simply modify their value and they will keep their meaning without needing to modify their names all along the file.

  Bonus tip for a better appearance: Some transition for the button hover status.

  Marked as helpful

  0

  ---

  

  Christian Patrick Nebab•1,080

  @Dng120696Posted over 1 year ago

  @franexmo81 thank you for recommendation man

  1
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  ---

  HEADINGS ⚠️:

  • This solution has generated accessibility error report due to skipping heading levels which warn us as "Heading levels should only increase by one"

  ---

  • We want to avoid skipping heading levels, make sure to start with <h1> and working your way down the heading levels (<h2>, <h3>, etc.) helps ensure that our document has a clear and consistent hierarchy. Read more 📚

  ---

  • Because skipping heading levels is a poor practice from the perspective of information design, whether we are talking about web pages, books, journal articles, or about anything else. You can not only confuse screen readers but all readers when you don't follow a consistent, logical pattern with your heading structure.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0