Results-summary-component

Community feedback

• 

  Biswarup Ghosh•80

  @biswarupgh0shPosted over 1 year ago

  Thanks for your kind review.

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  DECORATIVE SVG'S ♨️:

  • The alt attribute is used to provide alternative text for images in HTML documents. The alt attribute is used by screen readers to describe the image to visually impaired users, which is essential for web accessibility.

  ---

  • Now, when it comes to decorative SVGs, they are used purely for aesthetic purposes and do not convey any important information or functionality to the user.

  ---

  • Since these images do not convey any important information or functionality, there is no need for an alt attribute.

  ---

  • So feel free to set the alt attribute as "" for decorative svg's, because alt="" will be skipped by screen readers they will consider the image as decoration

  ---

  Example:

  <img src="images/decorative.svg" alt="">
  
  

  <img src="assets/images/icon-reaction.svg" alt="icon-reaction">
    👇
  <img src="assets/images/icon-reaction.svg" alt="">
  
  

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• 

  Josh•1,110

  @josh76543210Posted over 1 year ago

  Hello @biswarupgh0sh,

  Congratulations on completing the challenge!

  I do have a suggestion for you to improve the responsiveness of your page:

  Remove the fixed height from your result div. This property causes the component to always take up 60% of the viewport height which makes it to large on large screens and too small on small screens.

  .result {
    height: 60vh;
  }
  

  One more suggestion:

  Remove the max-width on the body. The body will already take up all of the width by default so you do not have to include this in your code.

  body {
    max-width: 100%;
  }
  

  Happy coding!

  0