results-summary-component

Community feedback

• 

  Phenics13•60

  @Phenics13Posted over 1 year ago

  Hi. I looked at your solution and have some suggestions.

  • to make component responsive, you use media queries and that is the only way to make component responsive. However, you can also use some properties in % value to make it stretch, max-width and max-height.
  • to make appear or disappear "Thankyou" component use useState hook in the parent component(<App/>) instead of doing it in <Ratings> component. Also learn more about different hooks in React.

  const [isSubmitted, setIsSubmitted] = useState(false)
  
  // in the App return block:
  
  return (
    {!showThankyou ? <Ratings/> : <Thankyou/>}
  );
  

  • add guard function that prevents user from submitting with 0 rating (because you can not pick zero) and only submit when any value 1-5 was picked.

  if (!selected) return;
  

  • to prevent props drilling you can use React Context (for selected number, for example)

  Hint: you can look at my solution of this challenge. It contains everything that I have mentioned here

  Marked as helpful

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the <div id="root"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0