Bryan Li• 3,550
@Zy8712
Posted
Your site looks pretty good. To anwer your question, your css seems to be about the right among for a project of this size. Some things I noticed when reading your code and testing out your site:
- your icon images are no loading in, this is due to how you linked your .svg files. Right now you have
/assets/images/icon-memory.svg. It should be./assets/images/icon-memory.svg - you should also add in hover effects for your button for some interactivity
- one other thing you should add in is a
<main>tag to wrap around your page's content, for accessibility purposes
Hope you find this feedback useful 👍
Marked as helpful
1
@nemoanderson
Posted
@Zy8712 after seeing another result, I noticed that there was hover on button, (should read the brief) and I played around with the images to figure out the issue with the icons. Thanks I added the main, which I usually do but for some reason I went ham on the divs. I will stick with semantic tags because of the suggestion. You rock. 🎸🎸🎸
0
