Results summary using Html, Css flexbox and grid
Design comparison
Solution retrospective
I completed the challenge but not sure if the way I use selectors and html structure is a good practice.
Community feedback
- @danielmrz-devPosted 11 months ago
Hello @giovanigomez1!
Your solution looks great!
I addition to what Melvin already told you, I have a couple more suggestions for improvement:
- For semantic reasons, and since that is the main title of the screen, you can replace the
<h2>with<h1>. This change is not just about the size of the text.
The
<h1>to<h6>tags are used to define HTML headings.<h1>defines the most important heading.<h6>defines the least important heading. Only use one<h1>per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with<h1>, then use<h2>, and so on.All these changes we are suggesting you may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful0 - For semantic reasons, and since that is the main title of the screen, you can replace the
- @MelvinAguilarPosted 11 months ago
Hello there 👋. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
- Use semantic elements such as
<main>and<footer>to improve accessibility and organization of your page.
- Avoid using the
<div>tag just for text.<div>is a generic container used for grouping content and applying styles, but it doesn't convey any semantic meaning. Similarly, avoid using<span>for entire blocks of text,<span>is an inline HTML element used to apply styles to specific parts of text without changing the structure or meaning, but this tag doesn't provide the same semantic value as other tags like paragraphs.
- For icons, you should still use the alt attribute, but it should be empty (
alt=""). This indicates to screen readers and other assistive technologies that the icon is decorative and that they should skip over it
I hope you find it useful! 😄
Happy coding!
Marked as helpful0@giovanigomez1Posted 11 months agoHi @MelvinAguilar, thanks for your feedback, I will implement it 😃.
0 - Use semantic elements such as
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord