Results Summary

Community feedback

• 

  P

  beowulf1958•1,450

  @beowulf1958Posted about 1 year ago

  Congratulations on completing this challenge! It looks great and is responsive.

  Two suggestions: I notice you use heading tags h2, h3 for styling. This is not a good practice; h2 is for a sub-heading of h1, h3 a subheading of h2, and so on. This can confuse screen readers.

  Also, the design called for an active state for the button: on active, the cursor: pointer and the background becomes a linear-gradient similar to the circle.

  Your code is very clean and readable. Hope this helps.

  Marked as helpful

  0

  ---

  

  CaseyLawver•40

  @CaseyLawverPosted about 1 year ago

  @beowulf1958 Thank you for your feedback! Would you suggest using p for those headings instead? I completely forgot about the active state for the button! I'm going to add that, thanks for pointing that out.

  0

  

  P

  beowulf1958•1,450

  @beowulf1958Posted about 1 year ago

  @CaseyLawver Yes, <p>. I reversed engineered your project with p tags and it worked fine. You have to specify first-of-type, last-of type, but otherwise your styles work.

  0
• 

  K01wfd•690

  @K01wfdPosted about 1 year ago

  Hi CaseyLawver, your solution looks good, some suggetions for your css codes:

  1. in your css file where you are reseting some styles in the global selector, i think using font-size of 18px there would make it bit hard especially for big projects, the default font size for the root element is 16px which is equvalent to 1rem, if you want to work with base 16px font size just leave it as default, or you can reset the font size for easier calculation like this html{font-size:62.5%} this will bring the font size of the root element to 62.5% which is 10px, so now just multiply by 10, and from there you can easiely calculate all sizes you want, 1rem now is 10px and so on.
  2. Always use relative units when working with sizes as much as you can (rem, em, %).
  3. in the summary section the inline-paddings are bit too small.

  hope this will help. Happy coding :)

  Marked as helpful

  0

  ---

  

  CaseyLawver•40

  @CaseyLawverPosted about 1 year ago

  @Korg01wfd Thank you for your feedback! This is super helpful.

  0