Design comparison
Solution retrospective
Hello!
This is my solution to the Results Summary Component challenge. Any and all feedback is most welcome! I do have a question as follows
Is my use of javascript and html templates appropriate to the challenge? I've played around with js and templates in my own mini projects and felt like it would be useful in this challenge as a potential real world solution, but I am unsure. Any thoughts or feedback would be most appreciated.
Thanks for checking out my solution!
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
LABELS π:
- There's a small issue with accessibility, inside the
summary__item
section.
- We want to nest the
/
inside theabbr
tag and want to add a title ofout of
, this helps the screen reader to properly announce the score to the user
- Example:
<abbr title="out of">/<abbr>
- Now the issue regarding accessibility has been resolved
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord