Skip to content
Submitted over 1 year ago

Results Summary (Css Flex Layout, Scss)💫

ezecoder•870
@3eze3
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Results summary component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

In this project is my first time working with Sass and maybe I have many errors or things that I could improve, so if you can tell me I would be really grateful, I wanted to complicate some things that I could have done with css but I wanted to force a little more Scss since I'm learning it. And finally the project I managed to do well in my opinion. Happy coding ❤

Community feedback

  • Tryt4n•960
    @Tryt4nPosted over 1 year ago

    In overall it's well written. BEM class architecture is good but folder structure could be better.

    src folder isn't asset

    In assets folder should be images, fonts, etc.

    For colors you could make new colors file

    In base folder you could split the base file into several different files. For example base, font-face, typography, helpers

    If you would have helpers file you could put there visually-hidden class and use it in your h1 instead of card__title--hidden because it's not modifier. You are just visually hiding this element from the user not modifying it.

    Marked as helpful
    1
    ezecoder•870
    @3eze3Posted over 1 year ago

    @Tryt4n Hey thanks for taking the time, and your advice, I will take it into account for my next projects. I really found them useful.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord