Results Summary Components project

Community feedback

• 

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  Congrats on completing the challenge successfully! Your submission looks great on desktop size. However it looks like you have optimized the solution spesific to one size of browser width (desktop view) by using width: 20vw; I'd say such approach could cause unwanted layout breaks for mobile view. A better practice would be to have a width: 100%, and a max-width: 300px for the .result. However usually it is better to have these properties for the parent container and let the children derive their width from the parents width. E.g. parent could have max-width of 800px or 600px and set to display:flex, and children could have flex:1, so the parent container is divided into two equal columns.

  Hope this was helpful!

  Marked as helpful

  0
• 

  kingsanwo9•100

  @kingsanwo9Posted over 1 year ago

  Hi, I noticed you do not have alt text in in your code and also a footer that has your name in it, You don't have to erase the footer as it is compulsory to have a footer in your code for reference. Hope its helpful.

  0