results summary components main using css grid and flexbox

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 9 months ago

  Hello @oyesina-paul!

  Your solution looks great!

  I have a suggestion:

  • Since you set grid to the body, but you didn't set the size of the rows, your footer is pushing your card up a little bit. You can prevent that from happening adding this to the body:

  grid-template-rows: 90% 1fr;
  

  Then your card will always occupy 90% of the space and the footer will adapt in the remaining space.

  I hope it helps!

  Other than that, you did an excellent job!

  0

  ---

  

  Oyesina Paul•90

  @oyesina-paulPosted 9 months ago

  Hello @danielmrz-dev

  Thanks a lot for your review. I really appreciate.

  When i tried setting the grid-template-rows: 90% 1fr; on my body. The space at the top of my card centering it dissappeared. What do you think caused that or is it just on my desktop?

  0