Design comparison
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
DECORATIVE SVG'S β¨οΈ:
- The
alt
attribute is used to provide alternative text for images in HTML documents. Thealt
attribute is used by screen readers to describe the image to visually impaired users, which is essential for web accessibility.
- Now, when it comes to decorative
SVGs
, they are used purely for aesthetic purposes and do not convey any important information or functionality to the user.
- Since these images do not convey any important information or functionality, there is no need for an
alt
attribute.
- So feel free to set the
alt
attribute as""
for decorativesvg's
, becausealt=""
will be skipped by screen readers they will consider the image as decoration
Example:
<img src="images/decorative.svg" alt="">
<img src="assets/images/icon-reaction.svg" alt="Reaction"> π <img src="assets/images/icon-reaction.svg" alt="">
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0@tulsirajputPosted over 1 year ago@0xAbdulKhalid Thank you for the suggestions. This is my first project and I will definitely work upon the mistakes.
0 - @Kamlesh0007Posted over 1 year ago
Congratulations on completing the challenge! That's a great achievement, and I'm sure you put a lot of effort into it. I really liked the way you approached the challenge and the code you wrote. You demonstrated a good understanding of the concepts and applied them effectively to solve the problem.I have a few suggestions to improve your code further
.score-left{ padding: 50px; width: 74px; height: 74px; border-radius:100% ; box-shadow: inset 0px 10px 12px 0px hsla(256, 72%, 46%, 1); //remove this display: flex; align-items: center; justify-content: center; flex-direction: column; margin: 0 auto; }
And also add responsiveness to code for mobile devices
Marked as helpful0@tulsirajputPosted over 1 year ago@Kamlesh0007 Thank you for the suggestions , I will definitely work on that.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord