Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Results summary component with simple JS

@AdamJou

Desktop design screenshot for the Results summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


On the mobile version my component is larger than the viewport so it causes a scroll bar to appear and I don't know how to fix it.

Community feedback

P
Cuong Ly 180

@cuonglyy

Posted

Hello there!

Congrats on finishing this project! Here are a couple of things I would recommend:

  • Use rem or em instead of px for your values as they are scalable units that provide accessibility.
  • It seems like min-height: 450px in your .wrapper class is causing your results component to add extra space at the bottom.
  • Since mobile design is a smaller view, resizing some components to a smaller size may help
  • Keeping display: grid in body element for your mobile view can help center the component

Happy Coding! (-:

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord