Results Summary Component with SCSS

Community feedback

• 

  Haiko•200

  @Haiko-EPosted almost 2 years ago

  Maybe a little different solution for your approach on the card. Remove align itemsand justify content. Remove gap on result and summary. set justify content to space between on result and summary. makes it more responsive...

  rows and row can sematicly be a ul with li's

  If you would to checkout mine, every feedback is welcome!

  You can see my solution here: https://www.frontendmentor.io/solutions/resultssummarycomponent-pkgZZXVKsw

  0
• 

  Abdul Khaliq 🚀•72,480

  @0xabdulkhaliqPosted almost 2 years ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the <div class="container"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0