Not Found
Request path contains unescaped characters
Request path contains unescaped characters
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Results Summary Component with Flexbox - Mobile First

EmilianoGomezAβ€’ 30

@EmilianoGomezA

Desktop design screenshot for the Results summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I couldn't find the way to add those rounded corners with a little more vivid color in the elements of summary section. If someone could tell me how to do it, I would really appreciate it.

Community feedback

Sumanth Chandanaβ€’ 720

@sumanth-chandana

Posted

Hi mate!, congratsπŸŽ‰ on completing the challenge. Better take care about following points.

  • Always check Frontendmentor Report Generator issues after submitting the project for removing errors and warnings.
  • Use the alt (alternate text) attribute as mentioned in your Accessibility Report. alt attribute is used for Screen readers applications.
  • Why does alt attribute matter? Read here.
  • To avoid accessibility issues "All page content should be contained by landmarks" use code as :
 <body>
    <main>
        ---your code here----
    </main>
  <footer>
  </footer>
</body>

(why does <main> matter? Read here )

  • For proper centering the container(whole card) vertically and horizontally you can also use the following simple block of code use code:
body {
    min-height: 100vh;
    display: grid;
    place-content: center;
}
  • When we open the GitHub repository link, you will find an About Section on the right side. There, also include a live preview link of your project. It is better for someone to check your live project while interacting with code.

I hope you will find this Feedback Helpful.

Marked as helpful

1
Abdul Khaliq πŸš€β€’ 72,660

@0xabdulkhaliq

Posted

Hello there πŸ‘‹. Congratulations on successfully completing the challenge! πŸŽ‰

  • I have other recommendations regarding your code that I believe will be of great interest to you.

HEIGHT πŸ“:

  • Use min-height: 100vh for main instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.
  • For example; if we set height: 100vh then the main will have 100vh height no matter what. Even if the content spans more than 100vh.
  • But if we set min-height: 100vh then the main will start at 100vh, if the content pushes the main beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

.

I hope you find this helpful πŸ˜„ Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

1
Manish Tamangβ€’ 80

@Manish-456

Posted

It would be better if you didn't specify height and width in section (.results__container)

1
SilentCoderβ€’ 20

@Jamiu10012

Posted

Great work keep it up

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord