Results Summary Component with Flexbox - Mobile First
Design comparison
Solution retrospective
I couldn't find the way to add those rounded corners with a little more vivid color in the elements of summary section. If someone could tell me how to do it, I would really appreciate it.
Community feedback
- @sumanth-chandanaPosted over 1 year ago
Hi mate!, congratsπ on completing the challenge. Better take care about following points.
- Always check Frontendmentor Report Generator issues after submitting the project for removing errors and warnings.
- Use the
alt
(alternate text) attribute as mentioned in your Accessibility Report.alt
attribute is used for Screen readers applications. - Why does alt attribute matter? Read here.
- To avoid accessibility issues "All page content should be contained by landmarks" use code as :
<body> <main> ---your code here---- </main> <footer> </footer> </body>
(why does
<main>
matter? Read here )- For proper centering the container(whole card) vertically and horizontally you can also use the following simple block of code use code:
body { min-height: 100vh; display: grid; place-content: center; }
- When we open the GitHub repository link, you will find an About Section on the right side. There, also include a live preview link of your project. It is better for someone to check your live project while interacting with code.
I hope you will find this Feedback Helpful.
Marked as helpful1 - @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
HEIGHT π:
- Use
min-height: 100vh
formain
instead ofheight: 100vh
. Setting theheight: 100vh
may result in the component being cut off on smaller screens.
- For example; if we set
height: 100vh
then themain
will have100vh
height no matter what. Even if the content spans more than100vh
.
- But if we set
min-height: 100vh
then themain
will start at100vh
, if the content pushes themain
beyond100vh
it will continue growing. However if you have content that takes less than100vh
it will still take100vh
in space.
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1 - @Manish-456Posted over 1 year ago
It would be better if you didn't specify height and width in section (.results__container)
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord