Submitted over 1 year ago

Results summary component

HeroLeam• 30

@HeroLeam

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

In my view it was a simple project to start my career, I had no difficulties, the project is visibly close to the challenge, I can't say if I did the development correctly and not to say the patterns in question of typing the codes.

If you can evaluate and mention points that I can improve, thank you!

Community feedback

Abdul Khaliq 🚀• 72,660

@0xabdulkhaliq

Posted over 1 year ago

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

I have other recommendations regarding your code that I believe will be of great interest to you.

DECORATIVE SVG'S ♨️:

The alt attribute is used to provide alternative text for images in HTML documents. The alt attribute is used by screen readers to describe the image to visually impaired users, which is essential for web accessibility.

Now, when it comes to decorative SVGs, they are used purely for aesthetic purposes and do not convey any important information or functionality to the user.

Since these images do not convey any important information or functionality, there is no need for an alt attribute.

So feel free to set the alt attribute as "" for decorative svg's, because alt="" will be skipped by screen readers they will consider the image as decoration

Example:

<img src="images/decorative.svg" alt="">

<img class="reaction-image" src="./images/icon-reaction.svg" alt="icon-reaction">
👇
<img class="reaction-image" src="./images/icon-reaction.svg" alt="">

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

ThanHtike（テンタイ）• 110

@CGM-ThanHtike

Posted over 1 year ago

Dear @heroleam, I had reviewed you code and found out some points that can be improved.

you style.css should be written at the lowest level in <head> tag because it might be overwrite by other other css classes, if u use bootstrap or other frameworks in the future.
form-circle-text-secundary, you should aware of your spellings (it might hurts sometimes)
Shouldn't use spam for everything, ex: <span class="form-summary-text">Summary</span> you can use h1 element here and <p> tag for paragraph.
You are declaring some unnecessary css properties like flex-direction: row; as the default flex-direction is row, u don't need to declare anything.

I think the [youtube video] will help. (https://www.youtube.com/watch?v=rxnX1jdoI6c&t=65s)

You wrote all css again in style-mobile.css. I'm not sure about landscape and portrait, however, if u use like @media(max-width: 768px), all the css you are declaring are effected also for mobile screens and all you need to do is modify some styles for mobile in media query.

Overall, You did a great job in making it almost same as the design. I'm also still learning to improve my skills and hope my review will help you to improve in some ways. Best Regards!

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord