Results summary component using SCSS

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component.

  body {
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  @media only screen and (min-width: 1024px)
  body {
  padding: 25rem 20rem;
  }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  • And along with that you want to wrap the both div elements with div element and apply these styles

  main {
  display: grid;
  grid-template-columns: 1fr 1fr;
  }
  

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  1

  ---

  

  P

  Malick Roungou•470

  @mroungouPosted over 1 year ago

  Thank you very much for the feed @0xAbdulKhalid! I will be looking at your suggestions and make the appropriate changes!

  0

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  @mroungou Glad you found it helpful ! 🤠

  0