luking• 230
@alululululuer
Posted
Hello! Here are some thoughts in my view.
- Aviod any horizontal scrollbar. Your media query min-width should set at least 750px, because your two parts width of this component seted to 375px and your min-width seted to 700px which smaller than the card width.
- Your BEM rules seem a little confused👀. I'm also learn BEM and I do not well too. "--"should be used as modifier. I think it maybe look better:
.card {} .card__result {} .card__summary {} .summary__wrapper--reaction {} .summary__wrapper--memory {}
Just from my perspective, hope it's helpful to you.
Marked as helpful
1
Bryan King Pecho• 230
@bkpecho
Posted
@alululululuer I was really having a hard time to think of class names for those! Thank you so much!
0