Design comparison
Solution retrospective
Hi, it was my first project, so every feedback is appreciated :). Thank you!
Community feedback
- @danielmrz-devPosted 9 months ago
Hello @evsta24!
Your solution looks great!
I have a couple of suggestions (about semantic HTML) for improvement:
π First: Use
<main>
to wrap the main content instead of<div>
.Tags like
<div>
and<span>
are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page.π Second: Use
<h1>
for the main title instead of<h2>
.Unlike what most people think, it's not just about the size and weight of the text.
- The
<h1>
to<h6>
tags are used to define HTML headings. <h1>
defines the most important heading.<h6>
defines the least important heading.- Only use one
<h1>
per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with<h1>
, then use<h2>
, and so on.
All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful1@evsta24Posted 9 months agoHello @danielmrz-dev,
thank you for the feedback, it helped. I forgot about HTML semantic elements. Thank you for the tips :)
1 - The
- @AlfredoPegueroCPosted 9 months ago
Hello, @evsta24
Your solution looks great!
Just need to add HTML semantic tags for your next project.
Leaving you a blog that explains why. freecodecamp and semrush.
I hope it helps.
PS: Sorry about my English; I'm still learning.
Marked as helpful1@evsta24Posted 9 months agoHello, @AlfredoPegueroC
thank you for the feedback and links to the websites. I completely forgot about HTML semantic tags. Thank you :)
P.S.: Your English is good and I'm learning English too.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord