Design comparison
Community feedback
- @kaamiikPosted 16 days ago
Congrats for doing this challenge. Just wanna say that:
-
Try to use a proper CSS reset at the start of your CSS style. Andy Bell and Josh Comeau both have a good one. You can simply search on the internet to find them.
-
Use
min-height: 100vh;
instead ofheight:100vh;
.height: 100vh
strictly limits the height to the viewport size, potentially causing overflow issues if the content is larger than the viewport. On the other hand,min-height: 100vh
allows your element to grow in height if the content exceeds the viewport size.
Marked as helpful0@MaxCoder-mcPosted 16 days ago@kaamiik Hello there, thank you for your comment. I already use Josh Comeau CSS reset on my other projects, I just didn't think its necessary on this one. But the (min-height: 100vh;) note will be taken, so... thanks again.
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord