Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Results Summary Component Solution using Next JS & Tailwind CSS

@arpit8392

Desktop design screenshot for the Results summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

P

@jairovg

Posted

Hi @arpit8392, congrats on your solution; here are some comments that might help you to improve it:

Accessibility and semantics

  • Here is your heading map:
Results Summary Component
3 Your Result
2 Great
1 Summary

Think about headings as a table of content of your site, they need to have a hierarchy. Here you can read more about heading structure.

  • There are some recurring categories in the summary section, is it a div the best semantic element for this?
  • Are the category icons adding something to your content? In case not, consider treating them as decorative images, removing their alt attribute.

Others

  • I recommend you set up prettier alongside your eslint config to get your code more readable and with the same structure. i.e.: you have some files using tabs and some others, probably config files, using spaces.
  • I'm wondering if you have all your react components in the app due to the challenge size, it would be good to see a different folder structure, no matter the challenge size, thinking in scalable projects.
  • Using colour variables linked to colour names, like red or yellow may take you to unnecessary refactors if the colour changes; instead, try to use variables scoped to features or categories using tokens.

I hope you find it useful. I'm happy to take another look at your solution if you make some other changes.

1

@asinarpit

Posted

Nice work man...but i think u forgot to add a background gradient to the bubble in the result box and also the background color of the body in the original design is white and u have to just use a box shadow at the bottom and right side of the main design....otherwise u did a great job👍

1

@arpit8392

Posted

Thanks @asinarpit for your feedback.

Here are my comments around both the suggestions:

  1. There was an issue with background gradient using tailwind CSS. I've deployed my latest build with the fixes.
  2. Background colour of the body is matching with Figma design so no further modifications are needed.

Appreciate your efforts!!!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord